Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 189623009: Make graph tool of dmprof useful (Closed)

Created:
6 years, 9 months ago by peria
Modified:
6 years, 9 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make a graph tool of dmprof useful. 1. Change the graph from bar-chart to area chat. Now x-axis shows time line. It is instinctive. 2. Enable to choose policies in GUI. It is a waste of time to apply many policies and make different HTML files. Now it can be done with clicks. No need to specify a policy in converting json to HTML. Usage: $ dmprof /path/to/first.heap > temp.json $ graph.py temp.json > graph.html # no need to specify a poilcy $ chrome graph.html # open the HTML file in Chrome BUG=None NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255764

Patch Set 1 #

Patch Set 2 : Add policy in graph title #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -44 lines) Patch
M tools/deep_memory_profiler/graph.py View 1 1 chunk +70 lines, -44 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
peria
Hi Mikurube-san, Would you take a look? I know graph.py is a mid-way tool, but ...
6 years, 9 months ago (2014-03-07 07:48:59 UTC) #1
kouhei (in TOK)
lgtm
6 years, 9 months ago (2014-03-07 07:58:34 UTC) #2
Dai Mikurube (NOT FULLTIME)
lgtm
6 years, 9 months ago (2014-03-07 20:41:29 UTC) #3
Dai Mikurube (NOT FULLTIME)
lgtm lgtm
6 years, 9 months ago (2014-03-07 20:41:30 UTC) #4
peria
The CQ bit was checked by peria@chromium.org
6 years, 9 months ago (2014-03-08 02:16:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/189623009/20001
6 years, 9 months ago (2014-03-08 11:18:06 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 12:04:11 UTC) #7
Message was sent while issue was closed.
Change committed as 255764

Powered by Google App Engine
This is Rietveld 408576698