Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189623004: UMA Histograms for Register Promos (Closed)

Created:
6 years, 9 months ago by Noam Samuel
Modified:
6 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

UMA Histograms for Register Promos Add UMA histograms for register promos. BUG=350228 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255827

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M chrome/browser/resources/print_preview/metrics.js View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/search/destination_search.js View 1 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Noam Samuel
6 years, 9 months ago (2014-03-07 01:33:44 UTC) #1
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/189623004/diff/1/chrome/browser/resources/print_preview/metrics.js File chrome/browser/resources/print_preview/metrics.js (right): https://codereview.chromium.org/189623004/diff/1/chrome/browser/resources/print_preview/metrics.js#newcode51 chrome/browser/resources/print_preview/metrics.js:51: REGISTER_PROMO_SELECTED: 7 +REGISTER_PROMO_SHOWN: ?
6 years, 9 months ago (2014-03-07 01:38:35 UTC) #2
Noam Samuel
https://codereview.chromium.org/189623004/diff/1/chrome/browser/resources/print_preview/metrics.js File chrome/browser/resources/print_preview/metrics.js (right): https://codereview.chromium.org/189623004/diff/1/chrome/browser/resources/print_preview/metrics.js#newcode51 chrome/browser/resources/print_preview/metrics.js:51: REGISTER_PROMO_SELECTED: 7 On 2014/03/07 01:38:35, Vitaly Buka wrote: > ...
6 years, 9 months ago (2014-03-07 18:12:53 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 9 months ago (2014-03-07 18:16:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/189623004/20001
6 years, 9 months ago (2014-03-07 18:18:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 18:23:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 18:23:10 UTC) #7
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-07 21:27:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/189623004/20001
6 years, 9 months ago (2014-03-07 21:27:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/189623004/20001
6 years, 9 months ago (2014-03-08 10:59:14 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 13:46:37 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234312
6 years, 9 months ago (2014-03-08 13:46:37 UTC) #12
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-09 04:34:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/189623004/20001
6 years, 9 months ago (2014-03-09 04:35:15 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 04:52:48 UTC) #15
Message was sent while issue was closed. 
Change committed as 255827

Powered by Google App Engine
This is Rietveld 408576698