Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Unified Diff: components/nacl/common/nacl_switches.cc

Issue 189623003: Dropping --nacl-loader-cmd-prefix (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/common/nacl_switches.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/common/nacl_switches.cc
diff --git a/components/nacl/common/nacl_switches.cc b/components/nacl/common/nacl_switches.cc
index b7ac04ef07451861bc3aeae141a5f483fe5f3e7b..a764e4e3da516369f40b874432fd00ab704b3f01 100644
--- a/components/nacl/common/nacl_switches.cc
+++ b/components/nacl/common/nacl_switches.cc
@@ -19,7 +19,7 @@ const char kEnableNaClDebug[] = "enable-nacl-debug";
// sandbox.
const char kEnableNaClNonSfiMode[] = "enable-nacl-nonsfi-mode";
-// Causes the process to run as a NativeClient broker
+// Option for --type that causes the process to run as a NativeClient broker
Mark Seaborn 2014/03/07 00:34:55 Nit: maybe "Option" -> "Value"?
bradn 2014/03/07 01:29:36 Done.
// (used for launching NaCl loader processes on 64-bit Windows).
const char kNaClBrokerProcess[] = "nacl-broker";
@@ -39,11 +39,7 @@ const char kNaClGdb[] = "nacl-gdb";
// GDB script to pass to the nacl-gdb debugger at startup.
const char kNaClGdbScript[] = "nacl-gdb-script";
-// On POSIX only: the contents of this flag are prepended to the nacl-loader
-// command line. Useful values might be "valgrind" or "xterm -e gdb --args".
-const char kNaClLoaderCmdPrefix[] = "nacl-loader-cmd-prefix";
-
-// Causes the process to run as a NativeClient loader.
+// Option for --type that causes the process to run as a NativeClient loader.
Mark Seaborn 2014/03/07 00:34:55 ditto
bradn 2014/03/07 01:29:36 Done.
const char kNaClLoaderProcess[] = "nacl-loader";
} // namespace switches
« no previous file with comments | « components/nacl/common/nacl_switches.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698