Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
189623003:
Dropping --nacl-loader-cmd-prefix (Closed)
|
Created:
6 years, 9 months ago by bradn Modified:
6 years, 9 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionDropping --nacl-loader-cmd-prefix
The --nacl-loader-cmd-prefix is no longer useful in practice for injecting a
debugger after this:
https://code.google.com/p/chromium/issues/detail?id=118263
https://src.chromium.org/viewvc/chrome?view=rev&revision=230891
We should drop the switch from chromium.
BUG=350158
TEST=None
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255782
Patch Set 1 #
Total comments: 4
Patch Set 2 : review fix #
Messages
Total messages: 25 (0 generated)
If you specify multiple reviewers, say what you want each to review. I think in this case I'm not needed (or, probably, a very good reviewer).
Sorry meant to cc you. Review to Nick. Mark for OWNERS. On Thu, Mar 6, 2014 at 4:30 PM, <pkasting@chromium.org> wrote: > If you specify multiple reviewers, say what you want each to review. > > I think in this case I'm not needed (or, probably, a very good reviewer). > > https://codereview.chromium.org/189623003/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
LGTM. Thanks for the cleanup. https://codereview.chromium.org/189623003/diff/1/components/nacl/common/nacl_... File components/nacl/common/nacl_switches.cc (right): https://codereview.chromium.org/189623003/diff/1/components/nacl/common/nacl_... components/nacl/common/nacl_switches.cc:22: // Option for --type that causes the process to run as a NativeClient broker Nit: maybe "Option" -> "Value"? https://codereview.chromium.org/189623003/diff/1/components/nacl/common/nacl_... components/nacl/common/nacl_switches.cc:42: // Option for --type that causes the process to run as a NativeClient loader. ditto
https://codereview.chromium.org/189623003/diff/1/components/nacl/common/nacl_... File components/nacl/common/nacl_switches.cc (right): https://codereview.chromium.org/189623003/diff/1/components/nacl/common/nacl_... components/nacl/common/nacl_switches.cc:22: // Option for --type that causes the process to run as a NativeClient broker On 2014/03/07 00:34:55, Mark Seaborn wrote: > Nit: maybe "Option" -> "Value"? Done. https://codereview.chromium.org/189623003/diff/1/components/nacl/common/nacl_... components/nacl/common/nacl_switches.cc:42: // Option for --type that causes the process to run as a NativeClient loader. On 2014/03/07 00:34:55, Mark Seaborn wrote: > ditto Done.
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/189623003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/189623003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/189623003/20001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/189623003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by mseaborn@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/189623003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/189623003/20001
Message was sent while issue was closed.
Change committed as 255782 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
