Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1896213002: Fixed flaky go tests in looper (Closed)

Created:
4 years, 8 months ago by Sergey Berezin
Modified:
4 years, 8 months ago
Reviewers:
dnj, seanmccullough
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use separate counter in advancing timer for thread safety #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -124 lines) Patch
M go/src/infra/monitoring/looper/looper_test.go View 1 3 chunks +82 lines, -124 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sergey Berezin
PTAL
4 years, 8 months ago (2016-04-19 18:14:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896213002/20001
4 years, 8 months ago (2016-04-19 18:20:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Infra Linux Trusty 64 Tester on tryserver.infra ...
4 years, 8 months ago (2016-04-19 18:27:56 UTC) #5
dnj
lgtm
4 years, 8 months ago (2016-04-19 18:32:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896213002/20001
4 years, 8 months ago (2016-04-19 21:12:56 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 21:25:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/cd857b9571bf1ad306f3513b82599...

Powered by Google App Engine
This is Rietveld 408576698