Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 1896203002: Search for a native extension for the host architecture (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Search for a native extension for the host architecture R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/1336e6149fa935ee4619d80f06eee21a8c95ca3e

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -45 lines) Patch
M runtime/bin/builtin.dart View 2 chunks +1 line, -17 lines 0 comments Download
M runtime/bin/builtin_natives.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/dartutils.cc View 2 chunks +9 lines, -15 lines 0 comments Download
M runtime/bin/extensions.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/extensions.cc View 2 chunks +28 lines, -3 lines 0 comments Download
M runtime/bin/platform.h View 2 chunks +22 lines, -1 line 0 comments Download
M runtime/bin/platform_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/standalone/io/test_extension_test.dart View 3 chunks +58 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 8 months ago (2016-04-19 17:58:29 UTC) #2
Ivan Posva
LGTM -ip
4 years, 8 months ago (2016-04-20 05:44:09 UTC) #3
zra
4 years, 8 months ago (2016-04-20 15:02:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1336e6149fa935ee4619d80f06eee21a8c95ca3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698