Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 1896173003: media: CHECK AVDATimerManager construction task runner is not null (Closed)

Created:
4 years, 8 months ago by xhwang
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: CHECK AVDATimerManager construction task runner is not null I suspect that the task runner is null for some reason which caused the crash in the bug. Since I can't repro locally, adding a CHECK so help investigation. BUG=604869 Committed: https://crrev.com/621ac80189cabe64e04963e3fcea943b4e379a76 Cr-Commit-Position: refs/heads/master@{#388552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
xhwang
PTAL
4 years, 8 months ago (2016-04-19 23:37:23 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 8 months ago (2016-04-20 18:26:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896173003/1
4 years, 8 months ago (2016-04-20 18:34:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 19:35:20 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/621ac80189cabe64e04963e3fcea943b4e379a76
Cr-Commit-Position: refs/heads/master@{#388552}

Powered by Google App Engine
This is Rietveld 408576698