build/toolchain/win/BUILD.gn - Issue 1896163003: Implement arflags in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/win/BUILD.gn

Issue 1896163003: Implement arflags in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@arflags

Patch Set: merge Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/win/BUILD.gn

diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn

index e2458e2624eb8e29a04629a3e18aece35f966d33..8e786187fb4b027ddfe113a7735cce87b4d67d6e 100644

--- a/build/toolchain/win/BUILD.gn

+++ b/build/toolchain/win/BUILD.gn

@@ -145,7 +145,7 @@ template("msvc_toolchain") {

tool("alink") {

rspfile = "{{output}}.rsp"

- command = "$python_path gyp-win-tool link-wrapper $env False $lib /nologo /ignore:4221 /OUT:{{output}} @$rspfile"

+ command = "$python_path gyp-win-tool link-wrapper $env False $lib /nologo {{arflags}} /OUT:{{output}} @$rspfile"

description = "LIB {{output}}"

outputs = [

# Ignore {{output_extension}} and always use .lib, there's no reason to

« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | no next file » | no next file with comments »