scripts/slave/recipes/closure_compilation.expected/main.json - Issue 1896113002: compile.py: explicitly pass gsutil.py path for uploading goma logs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/closure_compilation.expected/main.json

Issue 1896113002: compile.py: explicitly pass gsutil.py path for uploading goma logs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/webkit_tests_unexpected_error.json ('k') | scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.fyi",	8 "chromium.fyi",

9 "--builder",	9 "--builder",

10 "Closure Compilation Linux",	10 "Closure Compilation Linux",

(...skipping 104 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
115 "name": "generate_gyp_files"	115 "name": "generate_gyp_files"

116 },	116 },

117 {	117 {

118 "cmd": [	118 "cmd": [

119 "python",	119 "python",

120 "-u",	120 "-u",

121 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",	121 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",

122 "--show-path",	122 "--show-path",

123 "python",	123 "python",

124 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",	124 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",

	125 "--gsutil-py-path",

	126 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

125 "--ninja-path",	127 "--ninja-path",

126 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	128 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

127 "--target",	129 "--target",

128 "Release",	130 "Release",

129 "--src-dir",	131 "--src-dir",

130 "[SLAVE_BUILD]/src",	132 "[SLAVE_BUILD]/src",

131 "--goma-cache-dir",	133 "--goma-cache-dir",

132 "[GOMA_CACHE]",	134 "[GOMA_CACHE]",

133 "--build-tool",	135 "--build-tool",

134 "ninja",	136 "ninja",

(...skipping 11 matching lines...) Expand all Loading...
146 "name": "generate_v2_gyp_files"	148 "name": "generate_v2_gyp_files"

147 },	149 },

148 {	150 {

149 "cmd": [	151 "cmd": [

150 "python",	152 "python",

151 "-u",	153 "-u",

152 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",	154 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",

153 "--show-path",	155 "--show-path",

154 "python",	156 "python",

155 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",	157 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",

	158 "--gsutil-py-path",

	159 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

156 "--ninja-path",	160 "--ninja-path",

157 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	161 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

158 "--target",	162 "--target",

159 "Release",	163 "Release",

160 "--src-dir",	164 "--src-dir",

161 "[SLAVE_BUILD]/src",	165 "[SLAVE_BUILD]/src",

162 "--goma-cache-dir",	166 "--goma-cache-dir",

163 "[GOMA_CACHE]",	167 "[GOMA_CACHE]",

164 "--build-tool",	168 "--build-tool",

165 "ninja",	169 "ninja",

166 "--"	170 "--"

167 ],	171 ],

168 "cwd": "[SLAVE_BUILD]",	172 "cwd": "[SLAVE_BUILD]",

169 "name": "compile_v2"	173 "name": "compile_v2"

170 },	174 },

171 {	175 {

172 "name": "$result",	176 "name": "$result",

173 "recipe_result": null,	177 "recipe_result": null,

174 "status_code": 0	178 "status_code": 0

175 }	179 }

176 ]	180 ]

OLD	NEW