Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1896083002: [compiler] Remove remnants for old-skool live edit. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove remnants for old-skool live edit. This removes obsolete code that supports compiling without a shared function info object. Even for top-level code compiled for live edit such an object is allocated by now. R=yangguo@chromium.org Committed: https://crrev.com/d784c2d1eac1ce3fc6ea56beaa3e143e7065dc42 Cr-Commit-Position: refs/heads/master@{#35609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -21 lines) Patch
M src/compiler.cc View 5 chunks +4 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-19 09:00:33 UTC) #1
Yang
On 2016/04/19 09:00:33, Michael Starzinger wrote: nice! lgtm.
4 years, 8 months ago (2016-04-19 09:16:47 UTC) #2
Yang
On 2016/04/19 09:00:33, Michael Starzinger wrote: nice! lgtm.
4 years, 8 months ago (2016-04-19 09:16:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896083002/1
4 years, 8 months ago (2016-04-19 09:29:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 09:32:36 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 09:33:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d784c2d1eac1ce3fc6ea56beaa3e143e7065dc42
Cr-Commit-Position: refs/heads/master@{#35609}

Powered by Google App Engine
This is Rietveld 408576698