Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1896043002: WorkerNavigator: Remove deprecated Quota Management API. (Closed)

Created:
4 years, 8 months ago by Matt Giuca
Modified:
4 years, 8 months ago
Reviewers:
tkent, jsbell
CC:
blink-reviews, chrome-apps-syd-reviews_chromium.org, chromium-reviews, haraken, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WorkerNavigator: Remove deprecated Quota Management API. Removes webkitTemporaryStorage and webkitPersistentStorage from WorkerNavigator (which were available behind the enable-experimental-web-platform-features flag). Does not affect stable. These attributes were accidentally removed from stable in 2014 (due to https://crbug.com/604292) and nobody noticed. Since they are deprecated and non-standard, the decision has been made to remove these rather than reinstate them. BUG=604292 Committed: https://crrev.com/9bb2926b2514ffec767b574df4fa1f4e339e3eab Cr-Commit-Position: refs/heads/master@{#388361}

Patch Set 1 #

Patch Set 2 : Remove tests and update test expectations. #

Patch Set 3 : Update comment in IDL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -127 lines) Patch
D third_party/WebKit/LayoutTests/fast/workers/resources/storagequota-query-usage.js View 1 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/workers/resources/worker-storagequota-query-usage.js View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/workers/shared-worker-storagequota-query-usage.html View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/workers/shared-worker-storagequota-query-usage-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/workers/worker-storagequota-query-usage.html View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/workers/worker-storagequota-query-usage-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/WorkerNavigatorStorageQuota.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/WorkerNavigatorStorageQuota.cpp View 2 chunks +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/WorkerNavigatorStorageQuota.idl View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Matt Giuca
Continuing from discussion in https://codereview.chromium.org/1884423002/ tkent and jsbell have both expressed a preference to remove ...
4 years, 8 months ago (2016-04-19 03:11:02 UTC) #2
tkent
lgtm
4 years, 8 months ago (2016-04-19 03:18:15 UTC) #3
jsbell
lgtm
4 years, 8 months ago (2016-04-19 16:20:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896043002/40001
4 years, 8 months ago (2016-04-19 23:40:01 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-19 23:45:29 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:18:17 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9bb2926b2514ffec767b574df4fa1f4e339e3eab
Cr-Commit-Position: refs/heads/master@{#388361}

Powered by Google App Engine
This is Rietveld 408576698