base/i18n/streaming_utf8_validator.cc - Issue 189603007: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/i18n/streaming_utf8_validator.cc

Issue 189603007: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: For landing Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/i18n/streaming_utf8_validator.cc

diff --git a/base/i18n/streaming_utf8_validator.cc b/base/i18n/streaming_utf8_validator.cc

index 3838c9512434f74db4169969a101de3be265234c..c809985e168a2c67e2d68af028b9bb1f72c95bb4 100644

--- a/base/i18n/streaming_utf8_validator.cc

+++ b/base/i18n/streaming_utf8_validator.cc

@@ -15,10 +15,7 @@ namespace base {

namespace {

uint8 StateTableLookup(uint8 offset) {

- // Skip the bounds check on non-debug builds so that it isn't necessary to set

- // LOGGING_IS_OFFICIAL_BUILD just to do a performance test.

- if (logging::DEBUG_MODE)

- DCHECK_LT(offset, internal::kUtf8ValidatorTablesSize);

+ DCHECK_LT(offset, internal::kUtf8ValidatorTablesSize);

return internal::kUtf8ValidatorTables[offset];

}

« no previous file with comments | « base/base_switches.cc ('k') | base/logging.h » ('j') | no next file with comments »