Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/nacl/common/nacl_cmd_line.cc

Issue 189603007: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/common.gypi ('K') | « chrome/test/automation/proxy_launcher.cc ('k') | content/app/android/library_loader_hooks.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/common/nacl_cmd_line.cc
diff --git a/components/nacl/common/nacl_cmd_line.cc b/components/nacl/common/nacl_cmd_line.cc
index d9bbd6557f4a2d98022b0c4835cae8917e538cee..3ce4bb4e1e9fd1a0ed0d2c92a947fb23884d443d 100644
--- a/components/nacl/common/nacl_cmd_line.cc
+++ b/components/nacl/common/nacl_cmd_line.cc
@@ -23,8 +23,6 @@ void CopyNaClCommandLineArguments(CommandLine* cmd_line) {
switches::kEnableLogging,
switches::kDisableLogging,
switches::kLoggingLevel,
- switches::kEnableDCHECK,
- switches::kNoErrorDialogs,
Nico 2014/03/07 22:58:35 Did you delete kNoErrorDialogs intentionally?
Xianzhu 2014/03/07 23:29:36 Oh, sorry for the careless deletion. Restored.
#if defined(OS_MACOSX)
switches::kEnableSandboxLogging,
#endif
« build/common.gypi ('K') | « chrome/test/automation/proxy_launcher.cc ('k') | content/app/android/library_loader_hooks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698