Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: content/app/android/library_loader_hooks.cc

Issue 189603007: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/app/android/library_loader_hooks.cc
diff --git a/content/app/android/library_loader_hooks.cc b/content/app/android/library_loader_hooks.cc
index c6cb97cbd5ce73c4136b5233c38afe44fd2f2cf2..f69933f1367d205ec4031b8937de5603d3cf6f5d 100644
--- a/content/app/android/library_loader_hooks.cc
+++ b/content/app/android/library_loader_hooks.cc
@@ -95,15 +95,8 @@ bool LibraryLoaded(JNIEnv* env, jclass clazz,
// Can only use event tracing after setting up the command line.
TRACE_EVENT0("jni", "JNI_OnLoad continuation");
- // Note: because logging is setup here right after copying the command line
- // array from java to native up top of this method, any code that adds the
- // --enable-dcheck switch must do so on the Java side.
logging::LoggingSettings settings;
settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
- settings.dcheck_state =
- command_line->HasSwitch(switches::kEnableDCHECK) ?
- logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS :
- logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS;
logging::InitLogging(settings);
// To view log output with IDs and timestamps use "adb logcat -v threadtime".
logging::SetLogItems(false, // Process ID

Powered by Google App Engine
This is Rietveld 408576698