Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: chrome/test/automation/proxy_launcher.cc

Issue 189603007: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/proxy_launcher.cc
diff --git a/chrome/test/automation/proxy_launcher.cc b/chrome/test/automation/proxy_launcher.cc
index da9eba9bcd07725def4751ebeb323ebd1714e5df..6171f28d0e97ac34708b16fb1832ee713da8d390 100644
--- a/chrome/test/automation/proxy_launcher.cc
+++ b/chrome/test/automation/proxy_launcher.cc
@@ -122,8 +122,6 @@ ProxyLauncher::ProxyLauncher()
switches::kFullMemoryCrashReport)),
show_error_dialogs_(CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableErrorDialogs)),
- enable_dcheck_(CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableDCHECK)),
silent_dump_on_dcheck_(CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSilentDumpOnDCHECK)),
disable_breakpad_(CommandLine::ForCurrentProcess()->HasSwitch(
@@ -428,8 +426,6 @@ void ProxyLauncher::PrepareTestCommandline(CommandLine* command_line,
command_line->AppendSwitch(switches::kNoSandbox);
if (full_memory_dump_)
command_line->AppendSwitch(switches::kFullMemoryCrashReport);
- if (enable_dcheck_)
- command_line->AppendSwitch(switches::kEnableDCHECK);
if (silent_dump_on_dcheck_)
command_line->AppendSwitch(switches::kSilentDumpOnDCHECK);
if (disable_breakpad_)

Powered by Google App Engine
This is Rietveld 408576698