Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: components/nacl/common/nacl_cmd_line.cc

Issue 189603007: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/automation/proxy_launcher.cc ('k') | content/app/android/library_loader_hooks.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/base_switches.h" 5 #include "base/base_switches.h"
6 #include "base/basictypes.h" 6 #include "base/basictypes.h"
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "components/nacl/common/nacl_switches.h" 8 #include "components/nacl/common/nacl_switches.h"
9 #include "content/public/common/content_switches.h" 9 #include "content/public/common/content_switches.h"
10 10
11 namespace nacl { 11 namespace nacl {
12 12
13 void CopyNaClCommandLineArguments(CommandLine* cmd_line) { 13 void CopyNaClCommandLineArguments(CommandLine* cmd_line) {
14 const CommandLine& browser_command_line = *CommandLine::ForCurrentProcess(); 14 const CommandLine& browser_command_line = *CommandLine::ForCurrentProcess();
15 15
16 // Propagate the following switches to the NaCl loader command line (along 16 // Propagate the following switches to the NaCl loader command line (along
17 // with any associated values) if present in the browser command line. 17 // with any associated values) if present in the browser command line.
18 // TODO(gregoryd): check which flags of those below can be supported. 18 // TODO(gregoryd): check which flags of those below can be supported.
19 static const char* const kSwitchNames[] = { 19 static const char* const kSwitchNames[] = {
20 switches::kNoSandbox, 20 switches::kNoSandbox,
21 switches::kDisableBreakpad, 21 switches::kDisableBreakpad,
22 switches::kFullMemoryCrashReport, 22 switches::kFullMemoryCrashReport,
23 switches::kEnableLogging, 23 switches::kEnableLogging,
24 switches::kDisableLogging, 24 switches::kDisableLogging,
25 switches::kNoErrorDialogs,
Nico 2014/03/08 00:11:06 alphabetize (i.e. put it back in the same place wh
Xianzhu 2014/03/08 00:16:41 Done. (Sorry again for the carelessness)
25 switches::kLoggingLevel, 26 switches::kLoggingLevel,
26 switches::kEnableDCHECK,
27 switches::kNoErrorDialogs,
28 #if defined(OS_MACOSX) 27 #if defined(OS_MACOSX)
29 switches::kEnableSandboxLogging, 28 switches::kEnableSandboxLogging,
30 #endif 29 #endif
31 }; 30 };
32 cmd_line->CopySwitchesFrom(browser_command_line, kSwitchNames, 31 cmd_line->CopySwitchesFrom(browser_command_line, kSwitchNames,
33 arraysize(kSwitchNames)); 32 arraysize(kSwitchNames));
34 } 33 }
35 34
36 } // namespace nacl 35 } // namespace nacl
OLDNEW
« no previous file with comments | « chrome/test/automation/proxy_launcher.cc ('k') | content/app/android/library_loader_hooks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698