Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 189603005: Remove the --speech-service-key command line flag. (Closed)

Created:
6 years, 9 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, tommi (sloooow) - chröme
Visibility:
Public.

Description

Remove the --speech-service-key command line flag. It is not used anymore. The standard API keys workflow should be used instead. See http://www.chromium.org/developers/how-tos/api-keys. BUG=350333 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255749

Patch Set 1 #

Patch Set 2 : Remove GetAPIKey method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -22 lines) Patch
M content/browser/speech/google_streaming_remote_engine.cc View 1 4 chunks +2 lines, -18 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Primiano Tucci (use gerrit)
This is in response to the mail thread "ACTION REQUIRED: You are listed as an ...
6 years, 9 months ago (2014-03-07 09:38:02 UTC) #1
no longer working on chromium
On 2014/03/07 09:38:02, Primiano Tucci wrote: > This is in response to the mail thread ...
6 years, 9 months ago (2014-03-07 10:40:24 UTC) #2
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 9 months ago (2014-03-07 10:43:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/189603005/20001
6 years, 9 months ago (2014-03-07 10:44:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 11:13:17 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=54058
6 years, 9 months ago (2014-03-07 11:13:17 UTC) #6
Primiano Tucci (use gerrit)
+joi: can you please review the content_switch changes (I'm removing a switch)
6 years, 9 months ago (2014-03-07 13:46:55 UTC) #7
Jói
//content/public LGTM.
6 years, 9 months ago (2014-03-07 13:57:11 UTC) #8
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 9 months ago (2014-03-07 14:17:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/189603005/20001
6 years, 9 months ago (2014-03-07 14:18:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/189603005/20001
6 years, 9 months ago (2014-03-07 20:09:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/189603005/20001
6 years, 9 months ago (2014-03-08 10:44:02 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 11:27:42 UTC) #13
Message was sent while issue was closed.
Change committed as 255749

Powered by Google App Engine
This is Rietveld 408576698