Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart

Issue 1896023005: Issue 26207. Fix for renaming top-level functions with offset 0. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/format.fbs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart b/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
index 78a5cd44ecfe25b4baa4cf768d19166444983311..3715ced873b2f3dbcada0e5be78f540b369580af 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
@@ -496,6 +496,44 @@ main() {
''');
}
+ test_createChange_FunctionElement_imported() async {
+ indexUnit(
+ '/foo.dart',
+ r'''
+test() {}
+foo() {}
+''');
+ indexTestUnit('''
+import 'foo.dart';
+main() {
+ print(test);
+ print(test());
+ foo();
+}
+''');
+ // configure refactoring
+ createRenameRefactoringAtString('test);');
+ expect(refactoring.refactoringName, 'Rename Top-Level Function');
+ expect(refactoring.elementKindName, 'function');
+ expect(refactoring.oldName, 'test');
+ refactoring.newName = 'newName';
+ // validate change
+ await assertSuccessfulRefactoring('''
+import 'foo.dart';
+main() {
+ print(newName);
+ print(newName());
+ foo();
+}
+''');
+ assertFileChangeResult(
+ '/foo.dart',
+ '''
+newName() {}
+foo() {}
+''');
+ }
+
test_createChange_PropertyAccessorElement_getter_declaration() {
return _test_createChange_PropertyAccessorElement("test {}");
}
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/format.fbs » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698