Issue 1896023005: Issue 26207. Fix for renaming top-level functions with offset 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1896023005: Issue 26207. Fix for renaming top-level functions with offset 0. (Closed)

Created:
4 years, 8 months ago by scheglov

Modified:
4 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Issue 26207. Fix for renaming top-level functions with offset 0. They were indistinguishable from the corresponding enclosing units. Now we use a separate kind for units and libraries. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/26207 Committed: https://github.com/dart-lang/sdk/commit/daed53916a5c21731cf909cb8a808e3f69b81b68

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -4 lines)			Patch
M	pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart	View	1 chunk	+38 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/format.fbs	View	Binary file		0 comments	Download
M	pkg/analyzer/lib/src/summary/idl.dart	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/summary/index_unit.dart	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/index_unit_test.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 8 months ago (2016-04-19 22:36:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
daed53916a5c21731cf909cb8a808e3f69b81b68 (presubmit successful).