Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1896003003: Revert of Switch Android gtests to use generated wrapper scripts (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander_chromium, kjellander-cc_chromium.org, mikecase (-- gone --), bpastene, Sergey Berezin, perezju
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Switch Android gtests to use generated wrapper scripts (patchset #3 id:360001 of https://codereview.chromium.org/1898823002/ ) Reason for revert: Broke trybot analyze step: analyze output: { "compile_targets": [], "invalid_targets": [ "bin/run_android_webview_unittests", "bin/run_base_unittests", "bin/run_blink_heap_unittests", "bin/run_cc_unittests", "bin/run_components_browsertests", "bin/run_components_unittests", "bin/run_content_browsertests", "bin/run_content_unittests", "bin/run_device_unittests", "bin/run_events_unittests", "bin/run_gl_tests", "bin/run_gl_unittests", "bin/run_gpu_unittests", "bin/run_ipc_tests", "bin/run_media_unittests", "bin/run_net_unittests", "bin/run_sql_unittests", "bin/run_sync_unit_tests", "bin/run_ui_android_unittests", "bin/run_ui_base_unittests", "bin/run_ui_touch_selection_unittests", "bin/run_unit_tests" ], "status": "No dependencies", "test_targets": [] } Original issue's description: > Reland of Switch Android gtests to use generated wrapper scripts > > Now using bin/run_* script as a target to get around unit_tests ambiguity. > > BUG=599919 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300001 TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=599919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3425 lines, -2013 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 2 chunks +3 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/downgrade_install_tester_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_refs.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_try_builder_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/java_method_count_builder_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/last_known_devices_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/no_strict_mode_tester_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_adb_vendor_keys_basic.json View 2 chunks +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_low_battery_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_disable_location_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_user_build_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_failure.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/restart_usb_builder_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/slow_tester_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/specific_install_tester_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_blacklisted_devices.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_no_devices.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_offline_devices.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_other_device_failure.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/tester_with_step_warning.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_expected_failure.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexecuted_tests.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexpected_class_failure.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexpected_method_failure.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/webview_tester_basic.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipe_modules/cronet/example.expected/local_test.json View 4 chunks +10 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/emulator/example.expected/Disable_settings_after_launch_emulator_test_basic.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/amp_split_recipe_collect_failure.json View 11 chunks +60 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/amp_split_recipe_trigger_failure.json View 11 chunks +60 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_android_cloud_gtest.json View 2 chunks +7 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json View 1 chunk +0 lines, -20 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Remoting_Tests.json View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__amp_split_.json View 11 chunks +60 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Tests__trial__dbg_.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan_tester.json View 4 chunks +10 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_GN.json View 2 chunks +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_Android_Builder.json View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Android__Nexus4_.json View 2 chunks +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Builder_ARM64__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___K_Nexus5_.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus5_.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus6_.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus7_2_.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Tests__dbg___L_Nexus9_.json View 2 chunks +5 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_blink_rel.json View 4 chunks +12 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_chromium_gn_rel.json View 2 chunks +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 2 chunks +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder.json View 2 chunks +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json View 4 chunks +10 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json View 2 chunks +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_tester.json View 4 chunks +10 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/cronet_try.json View 4 chunks +10 lines, -2 lines 0 comments Download
M scripts/slave/recipes/cronet.expected/local_test.json View 4 chunks +10 lines, -2 lines 0 comments Download
M scripts/slave/recipes/emulator.py View 3 chunks +19 lines, -17 lines 0 comments Download
M scripts/slave/recipes/emulator.expected/Android_Tests__x86_emulator__test_basic.json View 13 chunks +137 lines, -97 lines 0 comments Download
M scripts/slave/recipes/emulator.expected/Android_Tests__x86_emulator__test_fail.json View 13 chunks +137 lines, -97 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json View 12 chunks +168 lines, -108 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__dbg_.json View 14 chunks +161 lines, -109 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json View 12 chunks +168 lines, -108 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__forced.json View 12 chunks +168 lines, -108 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2_.json View 12 chunks +168 lines, -108 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2__dbg_.json View 14 chunks +161 lines, -109 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_tests__l_nexus9_.json View 12 chunks +168 lines, -108 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 13 chunks +189 lines, -124 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json View 13 chunks +177 lines, -112 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json View 13 chunks +177 lines, -112 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json View 13 chunks +177 lines, -112 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 13 chunks +177 lines, -112 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 14 chunks +161 lines, -109 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_n6.json View 14 chunks +161 lines, -109 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 13 chunks +177 lines, -112 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
agrieve
Created Revert of Switch Android gtests to use generated wrapper scripts
4 years, 8 months ago (2016-04-19 01:50:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896003003/1
4 years, 8 months ago (2016-04-19 01:51:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300002
4 years, 8 months ago (2016-04-19 01:51:30 UTC) #4
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-19 01:53:41 UTC) #5
agrieve
4 years, 8 months ago (2016-04-19 14:33:38 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1897823006/ by agrieve@chromium.org.

The reason for reverting is: made _apk depend on wrapper script. Will reland
with adding run_ target gone..

Powered by Google App Engine
This is Rietveld 408576698