components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc - Issue 1895993003: Add migration code to change existing domain scoped content settings to be origin scoped

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

Issue 1895993003: Add migration code to change existing domain scoped content settings to be origin scoped (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove logs and format Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/content_settings/core/common/content_settings_pattern.cc ('K') | « components/content_settings/core/common/content_settings_pattern_unittest.cc ('k') | components/syncable_prefs/pref_model_associator.h » ('j') | components/syncable_prefs/pref_model_associator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

diff --git a/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc b/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

index c91203223d98aa95ac748128d678b08d3c613e35..eaead536f378ebf7d8ef19339ad77bb1a0f33058 100644

--- a/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

+++ b/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

@@ -313,7 +313,6 @@ TEST_F(PasswordManagerSettingMigratorServiceTest,

{ON, ON, ON, ON, true, N1L1, I11F11},

#endif

};

raymes 2016/06/16 03:23:51 nit: this isn't needed

lshang 2016/06/20 01:34:22 Done.

for (const auto& test_case : kTestingTable) {

SetupPreferenceMigrationEnvironment();

EnforcePasswordManagerSettingMigrationExperiment(kEnabledGroupName);