Add migration code to change existing domain scoped content settings to be origin scoped

components/content_settings/core/common/content_settings_pattern_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/content_settings/core/common/content_settings_pattern.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace {
@@ skipping 702 matching lines @@
   // file:/// normalization.
   EXPECT_STREQ("file:///tmp/test.html",
                Pattern("file:///tmp/bar/../test.html").ToString().c_str());
 
   // Invalid patterns.
   EXPECT_STREQ("", Pattern("*example.com").ToString().c_str());
   EXPECT_STREQ("", Pattern("example.*").ToString().c_str());
   EXPECT_STREQ("", Pattern("*\xC4\x87ira.com").ToString().c_str());
   EXPECT_STREQ("", Pattern("\xC4\x87ira.*").ToString().c_str());
 }
+
+TEST(ContentSettingsPatternTest, IsGeneratedUsingFromURL) {
+  // These are pattern styles which might be generated from FromURL().
+  EXPECT_TRUE(ContentSettingsPattern::FromString("[*.]example.com")
+                  .IsGeneratedUsingFromURL());
+  EXPECT_TRUE(ContentSettingsPattern::FromString("[*.]google.com:80")
+                  .IsGeneratedUsingFromURL());
+  EXPECT_TRUE(ContentSettingsPattern::FromString("https://[*.]google.com:443")
+                  .IsGeneratedUsingFromURL());
+  // These patterns either have an empty host, or have no domain wildcard, so
+  // they can not be generated from FromURL().
+  EXPECT_FALSE(
+      ContentSettingsPattern::FromString("*").IsGeneratedUsingFromURL());
+  EXPECT_FALSE(
+      ContentSettingsPattern::FromString("[*.]").IsGeneratedUsingFromURL());
+  EXPECT_FALSE(
+      ContentSettingsPattern::FromString("http://*").IsGeneratedUsingFromURL());
+  EXPECT_FALSE(ContentSettingsPattern::FromString("http://*:8080")
+                   .IsGeneratedUsingFromURL());
+  EXPECT_FALSE(ContentSettingsPattern::FromString("*://www.google.com:8080")
+                   .IsGeneratedUsingFromURL());
+  EXPECT_FALSE(ContentSettingsPattern::FromString("www.example.com:8080")
+                   .IsGeneratedUsingFromURL());
+  EXPECT_FALSE(ContentSettingsPattern::FromString("www.google.com/*")
+                   .IsGeneratedUsingFromURL());
+  EXPECT_FALSE(
+      ContentSettingsPattern::FromString("google").IsGeneratedUsingFromURL());
+  EXPECT_FALSE(ContentSettingsPattern::FromString("https://www.google.com")
+                   .IsGeneratedUsingFromURL());
+  EXPECT_FALSE(ContentSettingsPattern::FromString("https://www.google.com:443")
+                   .IsGeneratedUsingFromURL());
+  EXPECT_FALSE(ContentSettingsPattern::FromString("https://[*.]google.com")
+                   .IsGeneratedUsingFromURL());

[raymes, 2016/06/20 04:03:26]

We should make sure that the tests cover each of the cases that exist in the
function, e.g. we should have an example that uses a http scheme to check the
first condition.

[lshang, 2016/06/23 01:32:32]

Done.

+}
+
+TEST(ContentSettingsPatternTest, FromDomainToOrigin) {
+  EXPECT_STREQ(
+      "http://example.com:80",
+      ContentSettingsPattern::FromDomainToOrigin(Pattern("[*.]example.com"))
+          .ToString()
+          .c_str());

[raymes, 2016/06/20 04:03:26]

does expect_eq work, if you get rid of the call to c_str()?

[lshang, 2016/06/23 01:32:32]

Done.

+  EXPECT_STREQ(
+      "http://example.com:80",
+      ContentSettingsPattern::FromDomainToOrigin(Pattern("[*.]example.com:80"))
+          .ToString()
+          .c_str());
+  EXPECT_STREQ("https://example.com:443",
+               ContentSettingsPattern::FromDomainToOrigin(
+                   Pattern("https://[*.]example.com:443"))
+                   .ToString()
+                   .c_str());

[raymes, 2016/06/20 04:03:26]

We should also test a case with a port wildcard

[lshang, 2016/06/23 01:32:32]

Https patterns generated using FromURL() should always have a port (url's port
or https's default port 443 if url's port is empty).

[raymes, 2016/06/27 07:23:29]

Ahh that makes sense 

+}