Chromium Code Reviews Chromium Code Reviews
Issue 1895983002:
Adding UMA metrics to track usage of pointerevents. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-use-count.html |
| diff --git a/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-use-count.html b/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-use-count.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..f6ab06ad477a990096a15456fe28f880b683ca95 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-use-count.html |
| @@ -0,0 +1,65 @@ |
| +<!DOCTYPE HTML> |
| +<script src="../../../../../resources/js-test.js"></script> |
| +<style> |
| +div.box { |
| + margin: 5px; |
| + padding: 20px; |
| + float: left; |
| +} |
| +#grey { |
|
mustaq
2016/04/19 19:11:43
Nit: could join the two style entries since there'
sahel
2016/04/19 21:39:20
Done.
|
| + width: 50px; |
| + height: 50px; |
| +} |
| +</style> |
| + |
| +<div id="grey" class="box" style="background-color:grey"> |
| +</div> |
| + |
| +<div id="console"></div> |
| + |
| +<script> |
| +description("Verifies that use of pointerEvents is measured by use counters."); |
| + |
| + |
| +var rect = document.getElementById("grey").getBoundingClientRect(); |
| +var x1 = rect.left + 5; |
| +var y1 = rect.top + 5; |
| + |
| + |
| +function init() { |
| + var eventList = ["pointerover", "pointerenter", "pointermove", "pointerdown", "pointerup"]; |
| + |
| + var targetDiv = document.getElementById("grey"); |
| + eventList.forEach(function(eventName) { |
| + targetDiv.addEventListener(eventName, function(event) { |
| + if (event.eventPhase == Event.AT_TARGET) { |
|
tdresser
2016/04/19 17:52:00
We don't need to check the event phase here.
sahel
2016/04/19 21:39:20
Done.
|
| + debug("grey" + " received " + event.type); |
| + if (event.type == "pointerdown") { |
|
tdresser
2016/04/19 17:52:00
We don't need to check the event type here.
sahel
2016/04/19 21:39:20
I didn't want to print it for every event type. I
|
| + debug(" **** read pointerID to trigger MeasureAs ***** "); |
| + debug("pointerID is "+ event.pointerId); |
| + } |
| + } |
| + }); |
| + }); |
| + |
| +} |
| + |
| +function runTest() { |
| + debug(" **** Move to grey box & mouse press & jiggle ***** "); |
| + eventSender.mouseMoveTo(x1, y1); |
| + eventSender.mouseDown(1); |
| + eventSender.mouseMoveTo(x1+1, y1+1); |
| + eventSender.mouseUp(1); |
| + |
| + var PointerEventCount = 1306; |
|
mustaq
2016/04/19 19:11:43
Please add a comment to explain the number, e.g.:
sahel
2016/04/19 21:39:20
Done.
|
| + debug(" **** Print PointerEventCount usage ***** "); |
| + debug(internals.isUseCounted(document, PointerEventCount)); |
| +} |
| + |
| +init(); |
| +if (window.eventSender) |
| + runTest(); |
| +else |
| + debug("This test requires eventSender"); |
| + |
| +</script> |
