third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-use-count.html - Issue 1895983002: Adding UMA metrics to track usage of pointerevents.

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-use-count.html

Issue 1895983002: Adding UMA metrics to track usage of pointerevents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« GOATS ('K') | « GOATS ('k') | third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-use-count-expected.txt » ('j') | third_party/WebKit/Source/core/events/PointerEvent.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="../../../../../resources/js-test.js"></script>

	3 <style>

	4 div.box {

	5 margin: 5px;

	6 padding: 20px;

	7 float: left;

	8 }

	9 #grey {

	10 width: 50px;

	11 height: 50px;

	12 }

	13 </style>

	14

	15 <div id="grey" class="box" style="background-color:grey">

	16 </div>

	17

	18 <div id="console"></div>

	19

	20 <script>

	21 description("Verifies that use of pointerEvents is measured by use counters.");

	22

	23 var PointerEventCount = 1306;

	24

	25 var rect = document.getElementById("grey").getBoundingClientRect();

	26 var x1 = rect.left + 5;

	27 var y1 = rect.top + 5;

	28

	29

	30 function init() {

	31 var eventList = ["pointerenter", "pointerleave", "pointerover", "pointerout", "pointermove", "pointerdown", "pointerup",

	32 "gotpointercapture", "lostpointercapture"];
	tdresser 2016/04/19 12:43:20 I don't think we need to test every event type for I don't think we need to test every event type for this test, as all event types are treated the same. Let's just send a single pointerenter. sahel 2016/04/19 17:57:06 I omitted some of the events from the list. Show quoted text On 2016/04/19 12:43:20, tdresser wrote: > I don't think we need to test every event type for this test, as all event types > are treated the same. Let's just send a single pointerenter. I omitted some of the events from the list.
	33

	34 document.addEventListener("lostpointercapture", function(event) {

	35 if (event.eventPhase == Event.AT_TARGET) {

	36 debug("document received " + event.type);

	37 }

	38 });
	tdresser 2016/04/19 12:43:20 We don't need to explicitly test behavior of "lost We don't need to explicitly test behavior of "lostpointercapture" in this test, so we can remove this. sahel 2016/04/19 17:57:06 Done. Show quoted text On 2016/04/19 12:43:20, tdresser wrote: > We don't need to explicitly test behavior of "lostpointercapture" in this test, > so we can remove this. > Done.
	39 ["grey"].forEach(function(id) {
	tdresser 2016/04/19 12:43:20 This forEach looks unnecessary. This forEach looks unnecessary. sahel 2016/04/19 17:57:06 Done. Show quoted text On 2016/04/19 12:43:20, tdresser wrote: > This forEach looks unnecessary. Done.
	40 var targetDiv = document.getElementById(id);

	41 eventList.forEach(function(eventName) {

	42 targetDiv.addEventListener(eventName, function(event) {

	43 if (event.eventPhase == Event.AT_TARGET) {

	44 debug(id + " received " + event.type);

	45 if (event.type == "pointerdown") {

	46 debug(" ** Set Pointer Capture *** ");

	47 targetDiv.setPointerCapture(event.pointerId);
	tdresser 2016/04/19 12:43:20 We don't need to test pointer capture logic in thi We don't need to test pointer capture logic in this test. sahel 2016/04/19 17:57:06 No setPointerCapture anymore, just accessing point Show quoted text On 2016/04/19 12:43:20, tdresser wrote: > We don't need to test pointer capture logic in this test. No setPointerCapture anymore, just accessing pointerID of the event to trigger the MeasureAs.
	48 }

	49 }

	50 });

	51 });

	52 });

	53 }

	54

	55 function runTest() {

	56 debug(" ** Move to grey box & mouse press & jiggle *** ");

	57 eventSender.mouseMoveTo(x1, y1);

	58 eventSender.mouseDown(1);

	59 eventSender.mouseMoveTo(x1+1, y1+1);

	60

	61 debug(" ** Move to (0,0) *** ");

	62 eventSender.mouseMoveTo(0, 0);

	63

	64 debug(" ** Move back to grey & mouse release *** ");

	65 eventSender.mouseMoveTo(x1, y1);

	66 eventSender.mouseUp(1);

	67

	68 debug(" ** Print PointerEventCount usage *** ");

	69 debug(internals.isUseCounted(document, PointerEventCount));

	70 }

	71

	72 init();

	73 if (window.eventSender)

	74 runTest();

	75 else

	76 debug("This test requires eventSender");

	77

	78 </script>

OLD	NEW