src/full-codegen/full-codegen.cc - Issue 1895973002: Remove all non-function-name uses of CONST_LEGACY

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 1895973002: Remove all non-function-name uses of CONST_LEGACY (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix ignition Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index 1ac118ca916cd09220419e587a5e0c3e69a92718..45e8d68768b1863fab2efa22289e6cdf505219e9 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -1934,7 +1934,7 @@ bool FullCodeGenerator::NeedsHoleCheckForLoad(VariableProxy* proxy) {

DCHECK(var->initializer_position() != RelocInfo::kNoPosition);

DCHECK(proxy->position() != RelocInfo::kNoPosition);

- return var->mode() == CONST_LEGACY || var->scope()->is_nonlinear() ||

+ return var->scope()->is_nonlinear() ||

var->initializer_position() >= proxy->position();

}