Remove all non-function-name uses of CONST_LEGACY

Remove all non-function-name uses of CONST_LEGACY

Now that all 'const' declarations are of the ES2015 variety, the only
use of CONST_LEGACY is for function name bindings in sloppy mode
named function expressions.

This patch aims to delete all code meant to handle other cases, which
mostly had to do with hole initialization/hole checks. Since function
name bindings are initialized at entry to a function, it's impossible
to ever observe one in an uninitialized state.

To simplify the patch further, it removes the `IMPORT` VariableMode,
as it's not likely to be needed (IMPORT is identical to CONST for
the purpose of VariableMode).

Committed: https://crrev.com/59546149c600a2262339e82b6d24e407a71e7a98
Cr-Commit-Position: refs/heads/master@{#35632}

[adamk, 2016-04-18 21:42:26]

adamk@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Michael Starzinger, 2016-04-18 22:49:15]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-04-18 22:49:16]

LGTM, love it, just one actionable comment about BuildHoleCheckSilent.

https://codereview.chromium.org/1895973002/diff/40001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (left):

https://codereview.chromium.org/1895973002/diff/40001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:3385: value = BuildHoleCheckSilent(value,
undefined, value);
There should be no more call-sites of BuildHoleCheckSilent left, can we remove
it as well (both implementation and declaration in header file)?

https://codereview.chromium.org/1895973002/diff/40001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/1895973002/diff/40001/src/globals.h#newcode802
src/globals.h:802: VAR,  // declared via 'var', and 'function' declarations
Sometimes clang-format is working against us, but I can live with it. :/

https://codereview.chromium.org/1895973002/diff/40001/src/runtime/runtime-sco...
File src/runtime/runtime-scopes.cc (left):

https://codereview.chromium.org/1895973002/diff/40001/src/runtime/runtime-sco...
src/runtime/runtime-scopes.cc:342:
RUNTIME_FUNCTION(Runtime_InitializeLegacyConstLookupSlot) {
Awesome, love it!

[adamk, 2016-04-18 23:15:34]

Thanks for the review!

bmeurer, can you take a look at crankshaft?

https://codereview.chromium.org/1895973002/diff/40001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (left):

https://codereview.chromium.org/1895973002/diff/40001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:3385: value = BuildHoleCheckSilent(value,
undefined, value);
On 2016/04/18 22:49:16, Michael Starzinger wrote:
> There should be no more call-sites of BuildHoleCheckSilent left, can we remove
> it as well (both implementation and declaration in header file)?

Done. Also removed a few analogous bits from hydrogen-instructions.h.

[Benedikt Meurer, 2016-04-19 04:18:55]

Awesome! LGTM.

[adamk, 2016-04-19 17:00:59]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-04-19 17:01:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1895973002/#ps40002
(title: "Remove now-unused bits in TF and CS")

[commit-bot: I haz the power, 2016-04-19 17:01:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1895973002/40002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1895973002/40002

[commit-bot: I haz the power, 2016-04-19 17:03:32]

Committed patchset #4 (id:40002)

[nodir1, 2016-04-22 18:43:14]

Description was changed from

==========
Remove all non-function-name uses of CONST_LEGACY

Now that all 'const' declarations are of the ES2015 variety, the only
use of CONST_LEGACY is for function name bindings in sloppy mode
named function expressions.

This patch aims to delete all code meant to handle other cases, which
mostly had to do with hole initialization/hole checks. Since function
name bindings are initialized at entry to a function, it's impossible
to ever observe one in an uninitialized state.

To simplify the patch further, it removes the `IMPORT` VariableMode,
as it's not likely to be needed (IMPORT is identical to CONST for
the purpose of VariableMode).
==========

to

==========
Remove all non-function-name uses of CONST_LEGACY

Now that all 'const' declarations are of the ES2015 variety, the only
use of CONST_LEGACY is for function name bindings in sloppy mode
named function expressions.

This patch aims to delete all code meant to handle other cases, which
mostly had to do with hole initialization/hole checks. Since function
name bindings are initialized at entry to a function, it's impossible
to ever observe one in an uninitialized state.

To simplify the patch further, it removes the `IMPORT` VariableMode,
as it's not likely to be needed (IMPORT is identical to CONST for
the purpose of VariableMode).

Committed: https://crrev.com/59546149c600a2262339e82b6d24e407a71e7a98
Cr-Commit-Position: refs/heads/master@{#35632}
==========

[nodir1, 2016-04-22 18:43:15]

Patchset 4 (id:??) landed as
https://crrev.com/59546149c600a2262339e82b6d24e407a71e7a98
Cr-Commit-Position: refs/heads/master@{#35632}