Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1895923003: Verify a corner case of const constructor cycle detection with summaires. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Verify a corner case of const constructor cycle detection with summaires. We almost broke this with a recent CL so it seemed like a good idea to have an explicit unit test for it. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/746be6a723269883f0c5be64394811640a9a381f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-18 20:49:15 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-18 20:50:09 UTC) #3
Paul Berry
4 years, 8 months ago (2016-04-19 16:18:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
746be6a723269883f0c5be64394811640a9a381f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698