emit 'this.x' when 'super.x' accesses a field

lib/src/compiler/code_generator.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashMap, HashSet;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/dart/ast/token.dart' show Token, TokenType;
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
@@ skipping 3036 matching lines @@
     if (member is PropertyAccessorElement) {
       member = (member as PropertyAccessorElement).variable;
     }
     bool isStatic = member is ClassMemberElement && member.isStatic;
     var name = _emitMemberName(memberId.name,
         type: getStaticType(target), isStatic: isStatic);
     if (DynamicInvoke.get(target)) {
       return js.call('dart.dload(#, #)', [_visit(target), name]);
     }
 
+    if (target is SuperExpression &&
+        member is FieldElement &&
+        member.getter.isSynthetic) {

[vsm, 2016/04/18 20:27:43]

Do we need this for setters as well?

[Harry Terkelsen, 2016/04/18 20:59:50]

Doesn't synthetic getter imply synthetic setter? Actually, now that I think
about it, when we fix https://github.com/dart-lang/dev_compiler/issues/497 it
might be possible to have synthetic getters and implemented setters (the
synthetic getter is just a call to the super getter).

+      // If super.x is actually a field, then x is an instance property since
+      // subclasses cannot override x.
+      return js.call('this.#', [name]);
+    }
+
     String code;
     if (member != null && member is MethodElement && !isStatic) {
       // Tear-off methods: explicitly bind it.
       if (target is SuperExpression) {
         return js.call('dart.bind(this, #, #.#)', [name, _visit(target), name]);
       } else if (_requiresStaticDispatch(target, memberId.name)) {
         var type = member.type;
         var clos = js.call('dart.#.bind(#)', [name, _visit(target)]);
         return js.call('dart.fn(#, #)', [clos, _emitFunctionTypeParts(type)]);
       }
@@ skipping 682 matching lines @@
 }
 
 bool isLibraryPrefix(Expression node) =>
     node is SimpleIdentifier && node.staticElement is PrefixElement;
 
 LibraryElement _getLibrary(AnalysisContext c, String uri) =>
     c.computeLibraryElement(c.sourceFactory.forUri(uri));
 
 bool _isDartRuntime(LibraryElement l) =>
     l.isInSdk && l.source.uri.toString() == 'dart:_runtime';