third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp - Issue 1895873006: compositor-worker: Initialize CW machinery plumbing to compositor and fire CW rAF callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp

Issue 1895873006: compositor-worker: Initialize CW machinery plumbing to compositor and fire CW rAF callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bring up oilpan support during compositor worker creation and oilpan the compositor mutator and pro… Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/request-animation-frame.html ('K') | « third_party/WebKit/Source/core/page/ChromeClient.h ('k') | third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp » ('j') | third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp b/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp

index 18fb34ddf42f5fa6ecaf43c43aacd64868c830c8..5c931cd97cebb9b5720253d491e0ad6e67d08e54 100644

--- a/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp

@@ -29,6 +29,7 @@ WorkerBackingThread::WorkerBackingThread(WebThread* thread, bool shouldCallGCOnS

, m_isOwningThread(false)

, m_shouldCallGCOnShutdown(shouldCallGCOnShutdown)

{

+ thread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&WorkerBackingThread::initialize, AllowCrossThreadAccess(this)));

}

WorkerBackingThread::~WorkerBackingThread()

@@ -46,7 +47,8 @@ void WorkerBackingThread::attach()

if (++m_workerScriptCount > 1)

return;

}

- initialize();

+ if (m_isOwningThread)

+ initialize();

}

void WorkerBackingThread::detach()

@@ -56,7 +58,8 @@ void WorkerBackingThread::detach()

if (--m_workerScriptCount > 0)

return;

}

- shutdown();

+ if (m_isOwningThread)

+ shutdown();

}

void WorkerBackingThread::initialize()