Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: third_party/WebKit/Source/core/dom/CompositorProxyClient.h

Issue 1895873006: compositor-worker: Initialize CW machinery plumbing to compositor and fire CW rAF callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary scope Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/CompositorProxyClient.h
diff --git a/third_party/WebKit/Source/core/dom/CompositorProxyClient.h b/third_party/WebKit/Source/core/dom/CompositorProxyClient.h
new file mode 100644
index 0000000000000000000000000000000000000000..2bb59808f6a046db3779a2d10314b9556e58b089
--- /dev/null
+++ b/third_party/WebKit/Source/core/dom/CompositorProxyClient.h
@@ -0,0 +1,46 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CompositorProxyClient_h
+#define CompositorProxyClient_h
+
+#include "bindings/core/v8/ScopedPersistent.h"
+#include "core/CoreExport.h"
+#include "core/workers/WorkerClients.h"
+#include "platform/heap/Handle.h"
+#include "wtf/Noncopyable.h"
+
+#include <v8.h>
+
+namespace blink {
+
+class CompositorProxy;
+class Event;
+class ScriptState;
+class WorkerClients;
+class WorkerGlobalScope;
+
+class CORE_EXPORT CompositorProxyClient : public GarbageCollectedFinalized<CompositorProxyClient>, public Supplement<WorkerClients> {
jbroman 2016/04/20 19:24:51 Can this just be GarbageCollected<CompositorProxyC
flackr 2016/04/25 14:06:27 Yes, it totally can, done. In a future patch the d
+ WTF_MAKE_NONCOPYABLE(CompositorProxyClient);
+ USING_GARBAGE_COLLECTED_MIXIN(CompositorProxyClient);
+
+public:
+ CompositorProxyClient() {}
+ virtual ~CompositorProxyClient() {}
+ DEFINE_INLINE_VIRTUAL_TRACE() {}
+
+ static CompositorProxyClient* from(WorkerClients*);
+ static const char* supplementName();
+
+ virtual bool mutate(double time) = 0;
jbroman 2016/04/20 19:24:51 Here too, please explain what time is.
jbroman 2016/04/20 21:06:42 Does this method need to be virtual? Does anyone c
flackr 2016/04/25 14:06:27 I've changed this here and elsewhere to be monoton
+
+ virtual void setGlobalScope(WorkerGlobalScope*) = 0;
+ virtual void requestMutation() = 0;
jbroman 2016/04/20 21:06:42 This name feels strange (the caller is the one tha
flackr 2016/04/25 14:06:27 I agree, I think calling it requestAnimationFrame
+};
+
+CORE_EXPORT void provideCompositorProxyClientTo(WorkerClients*, CompositorProxyClient*);
+
+} // namespace blink
+
+#endif // CompositorProxyClient_h

Powered by Google App Engine
This is Rietveld 408576698