Issue 1895873005: [Android,VideoFling] Never add null players to alternative ones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1895873005: [Android,VideoFling] Never add null players to alternative ones (Closed)

Created:
4 years, 8 months ago by whywhat

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

[Android,VideoFling] Never add null players to alternative ones BUG=602851 TEST=existing tests The fix is a mere speculation from staring at the code. Review URL: https://codereview.chromium.org/1889233002 Cr-Commit-Position: refs/heads/master@{#387961} (cherry picked from commit 9af71a3cfca697a63586d334267829408d702d6a) Committed: https://chromium.googlesource.com/chromium/src/+/f0115acda9502cc79e19e627f95ea2947191f478

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
	M	chrome/browser/media/android/remote/remote_media_player_manager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/media/android/remote/remote_media_player_manager.cc	View		1 chunk	+13 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

whywhat

4 years, 8 months ago (2016-04-19 19:15:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f0115acda9502cc79e19e627f95ea2947191f478.