Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1895863004: Android stack tool: Treat /data/data as a synonym for /data/user/0. (Closed)

Created:
4 years, 8 months ago by jeffbrown
Modified:
4 years, 8 months ago
Reviewers:
etiennej, ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Android stack tool: Treat /data/data as a synonym for /data/user/0. The Mojo shell prints messages with paths in "/data/user/0" but the debugger may print paths with "/data/data". These paths are equivalent ("/data/data" is maintained for backwards compatibility) so make sure the stack tool understands that when it is mapping symbols. BUG= R=etiennej@chromium.org, ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/25cb8d470c629fbbdddf062181929455330f2925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M mojo/devtools/common/android_stack_parser/stack_utils.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jeffbrown
4 years, 8 months ago (2016-04-18 22:52:24 UTC) #2
etiennej
lgtm
4 years, 8 months ago (2016-04-19 07:41:54 UTC) #3
ppi
lgtm
4 years, 8 months ago (2016-04-19 07:51:06 UTC) #4
jeffbrown
4 years, 8 months ago (2016-04-19 20:21:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
25cb8d470c629fbbdddf062181929455330f2925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698