Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1895843002: MIPS: Use portable Printf formats. (Closed)

Created:
4 years, 8 months ago by balazs.kilvady
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Use portable Printf formats. BUG= Committed: https://crrev.com/6903ecbf24435c5bd0a12891c15d55d3a35f84eb Cr-Commit-Position: refs/heads/master@{#35591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -141 lines) Patch
M src/mips/simulator-mips.cc View 7 chunks +13 lines, -12 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 38 chunks +131 lines, -118 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
balazs.kilvady
4 years, 8 months ago (2016-04-18 16:09:18 UTC) #2
akos.palfi.imgtec
LGTM
4 years, 8 months ago (2016-04-18 16:13:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895843002/1
4 years, 8 months ago (2016-04-18 16:14:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 16:35:41 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 16:37:47 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6903ecbf24435c5bd0a12891c15d55d3a35f84eb
Cr-Commit-Position: refs/heads/master@{#35591}

Powered by Google App Engine
This is Rietveld 408576698