Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189583010: Remove yasm.gyp from all.gyp (Closed)

Created:
6 years, 9 months ago by r.c.ladan
Modified:
6 years, 9 months ago
Reviewers:
Nico, Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove yasm.gyp from all.gyp This allows 'gclient sync' to respect use_system_yasm=1 BUG=350593 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
r.c.ladan
6 years, 9 months ago (2014-03-08 00:40:27 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 9 months ago (2014-03-08 02:10:14 UTC) #2
Nico
lgtm stamp
6 years, 9 months ago (2014-03-08 02:11:30 UTC) #3
r.c.ladan
The CQ bit was checked by r.c.ladan@gmail.com
6 years, 9 months ago (2014-03-08 07:30:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/189583010/1
6 years, 9 months ago (2014-03-08 11:17:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:06:09 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234370
6 years, 9 months ago (2014-03-08 14:06:09 UTC) #7
r.c.ladan
The CQ bit was checked by r.c.ladan@gmail.com
6 years, 9 months ago (2014-03-09 09:59:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.c.ladan@gmail.com/189583010/1
6 years, 9 months ago (2014-03-09 09:59:46 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 12:58:00 UTC) #10
Message was sent while issue was closed. 
Change committed as 255847

Powered by Google App Engine
This is Rietveld 408576698