Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7449)

Unified Diff: chrome/renderer/extensions/cast_streaming_native_handler.cc

Issue 189583004: Cast: Implement log compression and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/cast_streaming_native_handler.h ('k') | chrome/renderer/media/cast_rtp_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/cast_streaming_native_handler.cc
diff --git a/chrome/renderer/extensions/cast_streaming_native_handler.cc b/chrome/renderer/extensions/cast_streaming_native_handler.cc
index 8cb45bf4bb06a52ad2add614f14ce986a1440fd2..cdeee65277266065766f3aa9cb0711e8d888a85a 100644
--- a/chrome/renderer/extensions/cast_streaming_native_handler.cc
+++ b/chrome/renderer/extensions/cast_streaming_native_handler.cc
@@ -480,7 +480,7 @@ void CastStreamingNativeHandler::GetStats(
void CastStreamingNativeHandler::CallGetRawEventsCallback(
int transport_id,
- scoped_ptr<std::string> raw_events) {
+ scoped_ptr<base::BinaryValue> raw_events) {
v8::Isolate* isolate = context()->isolate();
v8::HandleScope handle_scope(isolate);
v8::Context::Scope context_scope(context()->v8_context());
@@ -490,10 +490,9 @@ void CastStreamingNativeHandler::CallGetRawEventsCallback(
if (it == get_raw_events_callbacks_.end())
return;
v8::Handle<v8::Value> callback_args[1];
- callback_args[0] = v8::String::NewFromUtf8(isolate,
- raw_events->data(),
- v8::String::kNormalString,
- raw_events->size());
+ scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+ callback_args[0] =
+ converter->ToV8Value(raw_events.get(), context()->v8_context());
context()->CallFunction(it->second->NewHandle(isolate), 1, callback_args);
get_raw_events_callbacks_.erase(it);
}
« no previous file with comments | « chrome/renderer/extensions/cast_streaming_native_handler.h ('k') | chrome/renderer/media/cast_rtp_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698