Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 189583004: Cast: Implement log compression and (Closed)

Created:
6 years, 9 months ago by imcheng
Modified:
6 years, 9 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Log compression and getRawEvents JS API change. An additional bool argument in LogSerializer indicates the serialized log should be compressed. Compression will be done with zlib, and output will be in gzip format. An additional bool argument in LogDeserializer indicates the input is compressed and that a decompression should be performed before the actual deserialization. Changed LogSerializer API to only take data from 1 stream, since we are intending to output separate files for each stream anyway. CastSessionDelegate will always ask for logs compressed. Though it can be changed in the future. The sender app has been modified to allow the user to write logs to file in compressed format. The cast extension now works with base::BinaryValue rather than a std::string. The V8ValueConverter converts it to an ArrayBuffer object to JS. (A Blob can be constructed from it if desired) The JS API has changed so that getRawEvents returns an ArrayBuffer rather than a DOMString in the callback. BUG=301920, 338574 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256610

Patch Set 1 #

Patch Set 2 : Extension code now returns BinaryValue / Blob, no IDL change yet #

Patch Set 3 : Rebase #

Patch Set 4 : Changed IDL to return ArrayBuffer, changed js test #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -272 lines) Patch
M chrome/common/extensions/api/cast_streaming_rtp_stream.idl View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_session.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/media/cast_session_delegate.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/media/cast_session_delegate.cc View 1 2 3 3 chunks +18 lines, -14 lines 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/bad_logging.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/basics.js View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/common.js View 1 2 3 4 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/stats.js View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/DEPS View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/logging/log_deserializer.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M media/cast/logging/log_deserializer.cc View 1 2 3 3 chunks +80 lines, -11 lines 0 comments Download
M media/cast/logging/log_serializer.h View 1 2 3 1 chunk +18 lines, -49 lines 0 comments Download
M media/cast/logging/log_serializer.cc View 1 2 3 5 chunks +105 lines, -36 lines 0 comments Download
M media/cast/logging/serialize_deserialize_test.cc View 1 2 3 3 chunks +164 lines, -84 lines 0 comments Download
M media/cast/test/sender.cc View 1 2 3 7 chunks +88 lines, -52 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
imcheng
6 years, 9 months ago (2014-03-07 01:28:24 UTC) #1
imcheng
This patch is ready for review, PTAL, thanks.
6 years, 9 months ago (2014-03-10 22:55:22 UTC) #2
Alpha Left Google
lgtm
6 years, 9 months ago (2014-03-11 02:24:36 UTC) #3
imcheng
+kalman for native handler code. I modified the getRawEvents API so that it returns a ...
6 years, 9 months ago (2014-03-11 10:01:37 UTC) #4
not at google - send to devlin
lgtm
6 years, 9 months ago (2014-03-11 15:14:37 UTC) #5
Alpha Left Google
On 2014/03/11 15:14:37, kalman wrote: > lgtm LGTM for the Blob changes.
6 years, 9 months ago (2014-03-11 19:03:43 UTC) #6
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 9 months ago (2014-03-11 21:05:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/189583004/160001
6 years, 9 months ago (2014-03-11 22:08:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 23:00:46 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=54794
6 years, 9 months ago (2014-03-11 23:00:48 UTC) #10
imcheng
+brettw for media/cast/DEPS.
6 years, 9 months ago (2014-03-12 00:29:49 UTC) #11
brettw
DEPS LGTM
6 years, 9 months ago (2014-03-12 05:31:00 UTC) #12
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 9 months ago (2014-03-12 07:12:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/189583004/160001
6 years, 9 months ago (2014-03-12 08:04:28 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 08:46:39 UTC) #15
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=54895
6 years, 9 months ago (2014-03-12 08:46:40 UTC) #16
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 9 months ago (2014-03-12 09:38:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/189583004/180001
6 years, 9 months ago (2014-03-12 09:39:15 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 10:03:20 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-12 10:03:22 UTC) #20
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 9 months ago (2014-03-12 10:12:48 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/189583004/180001
6 years, 9 months ago (2014-03-12 10:15:28 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/189583004/180001
6 years, 9 months ago (2014-03-12 16:53:14 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/189583004/180001
6 years, 9 months ago (2014-03-12 19:12:37 UTC) #24
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 19:52:25 UTC) #25
Message was sent while issue was closed.
Change committed as 256610

Powered by Google App Engine
This is Rietveld 408576698