tools/ignition/linux_perf_report.py - Issue 1895793002: [Interpreter] Always show misattributed samples in linux_perf_report.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/ignition/linux_perf_report.py

Issue 1895793002: [Interpreter] Always show misattributed samples in linux_perf_report.py (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/ignition/linux_perf_report.py

diff --git a/tools/ignition/linux_perf_report.py b/tools/ignition/linux_perf_report.py

index d6fd55e38a0719a6019c06b9341fb98ec1bbf17f..fbf562c2abe9b699de7feb47b09446c90c9b19a2 100755

--- a/tools/ignition/linux_perf_report.py

+++ b/tools/ignition/linux_perf_report.py

@@ -115,7 +115,7 @@ def collapsed_callchains_generator(perf_stream, show_all=False,

elif symbol == "Builtin:InterpreterEntryTrampoline":

if len(current_chain) == 1:

yield ["[entry trampoline]"]

- elif show_all:

+ else:

# If we see an InterpreterEntryTrampoline which is not at the top of the

# chain and doesn't have a BytecodeHandler above it, then we have

# skipped the top BytecodeHandler due to the top-level stub not building

« no previous file with comments | « no previous file | no next file » | no next file with comments »