Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 1895793002: [Interpreter] Always show misattributed samples in linux_perf_report.py (Closed)

Created:
4 years, 8 months ago by Stefano Sanfilippo
Modified:
4 years, 8 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Always show misattributed samples in linux_perf_report.py Misattributed samples are strictly related to handlers, and the size of this special group helps understand how accurate the profile is. For these reasons, it makes more sense to always show this group. LOG=N BUG=v8:4899 Committed: https://crrev.com/5110f6c8819ec4ac3f406d65dca73b41ef9a6ad4 Cr-Commit-Position: refs/heads/master@{#35585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/ignition/linux_perf_report.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895793002/1
4 years, 8 months ago (2016-04-18 14:01:11 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 14:20:17 UTC) #5
Stefano Sanfilippo
4 years, 8 months ago (2016-04-18 14:53:41 UTC) #8
rmcilroy
LGTM, thanks.
4 years, 8 months ago (2016-04-18 15:01:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895793002/1
4 years, 8 months ago (2016-04-18 15:03:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 15:05:31 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 15:07:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5110f6c8819ec4ac3f406d65dca73b41ef9a6ad4
Cr-Commit-Position: refs/heads/master@{#35585}

Powered by Google App Engine
This is Rietveld 408576698