Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1895783004: Revert of 32-bit linux: Force 16-byte stack alignment. (Closed)

Created:
4 years, 8 months ago by adamk
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, Reid Kleckner
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of 32-bit linux: Force 16-byte stack alignment. (patchset #1 id:1 of https://codereview.chromium.org/1899783002/ ) Reason for revert: Broke InterpreterCreateArguments test on Linux nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/6404 Original issue's description: > 32-bit linux: Force 16-byte stack alignment. > > clang assumes 16-byte stack alignment, but incoming stack alignment isn't > always guaranteed to be that way. It looks like v8 was lucky to not hit > this so far. > > See https://crbug.com/418554 -- this makes v8's standalone config match > Chromium. See also https://llvm.org/bugs/show_bug.cgi?id=21414 > > Maybe it's possible to change the caller of OnEntryHook() to guarantee > the right alignment, but matching Chromium's build flags here seems like > a good idea in general. > > BUG=v8:4928 > LOG=n > > Committed: https://crrev.com/3afb3324941625559635380ef98a2ee73e370a0a > Cr-Commit-Position: refs/heads/master@{#35597} TBR=machenbach@chromium.org,rnk@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4928 Committed: https://crrev.com/8292435baa2c66fc7146f06ab0c088cc9b58d835 Cr-Commit-Position: refs/heads/master@{#35599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/standalone.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
adamk
Created Revert of 32-bit linux: Force 16-byte stack alignment.
4 years, 8 months ago (2016-04-18 22:00:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895783004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895783004/1
4 years, 8 months ago (2016-04-18 22:00:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 22:00:29 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 22:01:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8292435baa2c66fc7146f06ab0c088cc9b58d835
Cr-Commit-Position: refs/heads/master@{#35599}

Powered by Google App Engine
This is Rietveld 408576698