components/scheduler/renderer/renderer_scheduler_impl.h - Issue 1895773002: Move responsiblity of tab suspending from renderer to TabManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.h

Issue 1895773002: Move responsiblity of tab suspending from renderer to TabManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix time Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/memory/tab_manager.cc ('K') | « components/scheduler/renderer/renderer_scheduler.h ('k') | components/scheduler/renderer/renderer_scheduler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/renderer/renderer_scheduler_impl.h

diff --git a/components/scheduler/renderer/renderer_scheduler_impl.h b/components/scheduler/renderer/renderer_scheduler_impl.h

index 6c1628fc5aac3965717d89b8785bbf4ad988611f..3eb327437087a1cc016bd3a765b186fe1c67e80f 100644

--- a/components/scheduler/renderer/renderer_scheduler_impl.h

+++ b/components/scheduler/renderer/renderer_scheduler_impl.h

@@ -63,6 +63,7 @@ class SCHEDULER_EXPORT RendererSchedulerImpl

void DidAnimateForInputOnCompositorThread() override;

void OnRendererBackgrounded() override;

void OnRendererForegrounded() override;

+ void OnRendererSuspend() override;

void AddPendingNavigation() override;

void RemovePendingNavigation() override;

void OnNavigationStarted() override;

@@ -310,7 +311,6 @@ class SCHEDULER_EXPORT RendererSchedulerImpl

base::Closure update_policy_closure_;

DeadlineTaskRunner delayed_update_policy_runner_;

CancelableClosureHolder end_renderer_hidden_idle_period_closure_;

- CancelableClosureHolder suspend_timers_when_backgrounded_closure_;

// We have decided to improve thread safety at the cost of some boilerplate

// (the accessors) for the following data members.