Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1895753002: Polish EmbedderHeapTracer and move some checks from blink to v8 (Closed)

Created:
4 years, 8 months ago by Marcel Hlopko
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Polish EmbedderHeapTracer and move some checks from blink to v8 Quick one, ptal. BUG=468240 LOG=no Committed: https://crrev.com/0eae5650dec265e961a1024fd2090301f2cdca16 Cr-Commit-Position: refs/heads/master@{#35578} Committed: https://crrev.com/be9b87aafc92c4e38436f2abea35d955c7143806 Cr-Commit-Position: refs/heads/master@{#35594}

Patch Set 1 #

Patch Set 2 : Rename TraceWrappableFrom to TraceWrappersFrom to be consistent with blink' #

Patch Set 3 : Fixing broken condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/mark-compact.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-04-18 12:13:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895753002/20001
4 years, 8 months ago (2016-04-18 12:14:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 12:38:46 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0eae5650dec265e961a1024fd2090301f2cdca16 Cr-Commit-Position: refs/heads/master@{#35578}
4 years, 8 months ago (2016-04-18 12:39:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895753002/40001
4 years, 8 months ago (2016-04-18 17:33:38 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-18 17:59:19 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 17:59:54 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/be9b87aafc92c4e38436f2abea35d955c7143806
Cr-Commit-Position: refs/heads/master@{#35594}

Powered by Google App Engine
This is Rietveld 408576698