source/row_mips.cc - Issue 1895743008: Remove initialize to zero on output variables for inline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: source/row_mips.cc

Issue 1895743008: Remove initialize to zero on output variables for inline. (Closed) Base URL: https://chromium.googlesource.com/libyuv/libyuv@master

Patch Set: use early write for all outputs to avoid them being reassigned to input Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: source/row_mips.cc

diff --git a/source/row_mips.cc b/source/row_mips.cc

index 2c55b786b2a035f270059cc4f16d26696f231b02..ca6ecce94fa25c791ee36e6bac0a8a7b19c38156 100644

--- a/source/row_mips.cc

+++ b/source/row_mips.cc

@@ -498,8 +498,8 @@ void MirrorRow_DSPR2(const uint8* src, uint8* dst, int width) {

void MirrorUVRow_DSPR2(const uint8* src_uv, uint8* dst_u, uint8* dst_v,

int width) {

- int x = 0;

- int y = 0;

+ int x;

+ int y;

__asm__ __volatile__ (

".set push \n"

".set noreorder \n"

@@ -579,7 +579,7 @@ void MirrorUVRow_DSPR2(const uint8* src_uv, uint8* dst_u, uint8* dst_v,

[dst_u] "+r" (dst_u),

[dst_v] "+r" (dst_v),

[x] "=&r" (x),

- [y] "+r" (y)

+ [y] "=&r" (y)

: [width] "r" (width)

: "t0", "t1", "t2", "t3", "t4",

"t5", "t7", "t8", "t9"

« no previous file with comments | « source/row_gcc.cc ('k') | source/scale_gcc.cc » ('j') | no next file with comments »