source/rotate_neon64.cc - Issue 1895743008: Remove initialize to zero on output variables for inline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: source/rotate_neon64.cc

Issue 1895743008: Remove initialize to zero on output variables for inline. (Closed) Base URL: https://chromium.googlesource.com/libyuv/libyuv@master

Patch Set: use early write for all outputs to avoid them being reassigned to input Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: source/rotate_neon64.cc

diff --git a/source/rotate_neon64.cc b/source/rotate_neon64.cc

index f52c082b3fea9d3dcefe9d79800a990c8044526d..1ab448f3ab4c70ef75343d4da3ee5c8f241d9d8e 100644

--- a/source/rotate_neon64.cc

+++ b/source/rotate_neon64.cc

@@ -26,7 +26,7 @@ static uvec8 kVTbl4x4Transpose =

void TransposeWx8_NEON(const uint8* src, int src_stride,

uint8* dst, int dst_stride, int width) {

- const uint8* src_temp = NULL;

+ const uint8* src_temp;

int64 width64 = (int64) width; // Work around clang 3.4 warning.

asm volatile (

// loops are on blocks of 8. loop will stop when

@@ -235,7 +235,7 @@ void TransposeWx8_NEON(const uint8* src, int src_stride,

"4: \n"

- : "+r"(src_temp), // %0

+ : "=&r"(src_temp), // %0

"+r"(src), // %1

"+r"(dst), // %2

"+r"(width64) // %3

@@ -255,7 +255,7 @@ void TransposeUVWx8_NEON(const uint8* src, int src_stride,

uint8* dst_a, int dst_stride_a,

uint8* dst_b, int dst_stride_b,

int width) {

- const uint8* src_temp = NULL;

+ const uint8* src_temp;

int64 width64 = (int64) width; // Work around clang 3.4 warning.

asm volatile (

// loops are on blocks of 8. loop will stop when

@@ -520,7 +520,7 @@ void TransposeUVWx8_NEON(const uint8* src, int src_stride,

"4: \n"

- : "+r"(src_temp), // %0

+ : "=&r"(src_temp), // %0

"+r"(src), // %1

"+r"(dst_a), // %2

"+r"(dst_b), // %3

« no previous file with comments | « source/rotate_neon.cc ('k') | source/row_gcc.cc » ('j') | no next file with comments »