Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 1895743008: Remove initialize to zero on output variables for inline. (Closed)

Created:
4 years, 8 months ago by fbarchard1
Modified:
4 years, 8 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Remove initialize to zero on output variables for inline. Inline that uses temporary variables is currently initializing them to 0 and passing in as output "+r". This CL replaces the output constraint to "=&r" for most meaning an output with early write (before inputs). This allows the initialize to zero step to be removed, saving 1 instruction. BUG=libyuv:580 TESTED=local libyuv build on gcc/linux and try bots R=harryjin@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/cf101116c977d8c452d2e5b690c30c04da7519c8

Patch Set 1 #

Patch Set 2 : unattenuate use =&r for early output #

Patch Set 3 : use early write for all outputs to avoid them being reassigned to input #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -116 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/rotate_neon.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M source/rotate_neon64.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M source/row_gcc.cc View 1 2 16 chunks +43 lines, -43 lines 0 comments Download
M source/row_mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M source/scale_gcc.cc View 1 2 12 chunks +30 lines, -30 lines 0 comments Download
M source/scale_neon.cc View 1 2 4 chunks +15 lines, -15 lines 0 comments Download
M source/scale_neon64.cc View 1 2 4 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
fbarchard1
4 years, 8 months ago (2016-04-18 22:17:01 UTC) #1
harryjin
lgtm
4 years, 8 months ago (2016-04-18 22:38:57 UTC) #2
fbarchard1
4 years, 8 months ago (2016-04-18 23:24:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
cf101116c977d8c452d2e5b690c30c04da7519c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698