Source/web/WebViewImpl.h - Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.h

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improved downcast checking. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.h

diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h

index 54fe72f083b8b5a329fd9f18b75add1a2a79bf7f..5ca430ed1837770f146b20df6dced93e6b181866 100644

--- a/Source/web/WebViewImpl.h

+++ b/Source/web/WebViewImpl.h

@@ -62,13 +62,14 @@

#include "wtf/Vector.h"

namespace WebCore {

-class DataObject;

class Color;

-class LocalFrame;

+class DataObject;

+class Frame;

class GraphicsLayerFactory;

class HistoryItem;

class HitTestResult;

class KeyboardEvent;

+class LocalFrame;

dcheng 2014/03/17 18:17:44 Why the forward declare for Color and LocalFrame?

kenrb 2014/03/18 20:01:19 Removed.

class Page;

class PagePopup;

class PagePopupClient;

@@ -316,7 +317,7 @@ public:

return m_lastMouseDownPoint;

}

- WebCore::LocalFrame* focusedWebCoreFrame() const;

+ WebCore::Frame* focusedWebCoreFrame() const;

// Returns the currently focused Element or null if no element has focus.

WebCore::Element* focusedElement() const;

« Source/web/ContextMenuClientImpl.cpp ('K') | « Source/web/WebPageSerializer.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | Source/web/WebViewImpl.cpp » ('J')