Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Unified Diff: Source/core/page/PageSerializer.cpp

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improved downcast checking. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/PageSerializer.cpp
diff --git a/Source/core/page/PageSerializer.cpp b/Source/core/page/PageSerializer.cpp
index 6cff82f3532b51622b593c30c1776647c8eedd4c..419df01750cde6d85e68cfc9ef171fe5fe566d36 100644
--- a/Source/core/page/PageSerializer.cpp
+++ b/Source/core/page/PageSerializer.cpp
@@ -154,16 +154,17 @@ void SerializerMarkupAccumulator::appendCustomAttributes(StringBuilder& out, con
return;
const HTMLFrameOwnerElement& frameOwner = toHTMLFrameOwnerElement(element);
- LocalFrame* frame = frameOwner.contentFrame();
- if (!frame)
+ Frame* frame = frameOwner.contentFrame();
+ // RemoteFrames not currently supported here.
dcheng 2014/03/17 18:17:44 But eventually, right? Maybe tag with a FIXME? An
kenrb 2014/03/18 20:01:19 I've added a FIXME, but I don't know this area of
+ if (!frame || !frame->isLocalFrame())
return;
- KURL url = frame->document()->url();
+ KURL url = toLocalFrame(frame)->document()->url();
if (url.isValid() && !url.isBlankURL())
return;
// We need to give a fake location to blank frames so they can be referenced by the serialized frame.
- url = m_serializer->urlForBlankFrame(frame);
+ url = m_serializer->urlForBlankFrame(toLocalFrame(frame));
appendAttribute(out, element, Attribute(frameOwnerURLAttributeName(frameOwner), AtomicString(url.string())), namespaces);
}

Powered by Google App Engine
This is Rietveld 408576698