Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp - Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improved downcast checking. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

index c9e108b54a5fbd38d36546a1f45ae6cca96a71e7..5bd82003966c8b984bb96e5dd53765fbbfd5f34d 100644

--- a/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

@@ -35,6 +35,7 @@

#include "bindings/v8/BindingSecurity.h"

#include "bindings/v8/ExceptionState.h"

#include "bindings/v8/V8Binding.h"

+#include "core/frame/LocalFrame.h"

dcheng 2014/03/17 18:17:44 Not clear what this new include is for.

kenrb 2014/03/18 20:01:19 Oops, not needed. I had originally added it when l

#include "core/html/HTMLFrameElement.h"

#include "core/html/parser/HTMLParserIdioms.h"

« Source/bindings/v8/BindingSecurity.h ('K') | « Source/bindings/v8/V8WindowShell.cpp ('k') | Source/core/dom/Document.cpp » ('j') | Source/core/dom/TreeScope.cpp » ('J')