Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: Source/bindings/v8/BindingSecurity.h

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improved downcast checking. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/BindingSecurity.h
diff --git a/Source/bindings/v8/BindingSecurity.h b/Source/bindings/v8/BindingSecurity.h
index 66db9920142a2f2c282e03578f0b85e6a5a2f78e..390eada0178608ab570d687c749d5e66a674a1de 100644
--- a/Source/bindings/v8/BindingSecurity.h
+++ b/Source/bindings/v8/BindingSecurity.h
@@ -31,6 +31,7 @@
#ifndef BindingSecurity_h
#define BindingSecurity_h
+#include "core/frame/LocalFrame.h"
dcheng 2014/03/17 18:17:44 Hm... can't this have remained a forward include?
kenrb 2014/03/18 20:01:19 No because a lot of clients call shouldAllowAccess
dcheng 2014/03/19 20:50:03 Ugh. I think this is OK temporarily but we should
#include "wtf/text/WTFString.h"
#include <v8.h>
@@ -38,7 +39,6 @@ namespace WebCore {
class DOMWindow;
class ExceptionState;
-class LocalFrame;
class Node;
enum SecurityReportingOption {
@@ -49,8 +49,8 @@ enum SecurityReportingOption {
class BindingSecurity {
public:
static bool shouldAllowAccessToNode(v8::Isolate*, Node*, ExceptionState&);
- static bool shouldAllowAccessToFrame(v8::Isolate*, LocalFrame*, SecurityReportingOption = ReportSecurityError);
- static bool shouldAllowAccessToFrame(v8::Isolate*, LocalFrame*, ExceptionState&);
+ static bool shouldAllowAccessToFrame(v8::Isolate*, Frame*, SecurityReportingOption = ReportSecurityError);
+ static bool shouldAllowAccessToFrame(v8::Isolate*, Frame*, ExceptionState&);
};
}
« no previous file with comments | « no previous file | Source/bindings/v8/BindingSecurity.cpp » ('j') | Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698