Source/bindings/v8/V8WindowShell.cpp - Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Missed a null check Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/V8WindowShell.cpp

diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp

index cde61685fcf463e61cdaee21dfe88a0807864056..5e742fe3d89277f4a7cfa5a028a612241f46f820 100644

--- a/Source/bindings/v8/V8WindowShell.cpp

+++ b/Source/bindings/v8/V8WindowShell.cpp

@@ -434,7 +434,7 @@ static v8::Handle<v8::Value> getNamedProperty(HTMLDocument* htmlDocument, const

if (items->hasExactlyOneItem()) {

Element* element = items->item(0);

ASSERT(element);

- LocalFrame* frame = 0;

+ Frame* frame = 0;

if (isHTMLIFrameElement(*element) && (frame = toHTMLIFrameElement(*element).contentFrame()))

return toV8(frame->domWindow(), creationContext, isolate);

return toV8(element, creationContext, isolate);

« no previous file with comments | « Source/bindings/v8/BindingSecurity.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »