Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: Source/bindings/v8/BindingSecurity.h

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Missed a null check Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/BindingSecurity.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/BindingSecurity.h
diff --git a/Source/bindings/v8/BindingSecurity.h b/Source/bindings/v8/BindingSecurity.h
index 66db9920142a2f2c282e03578f0b85e6a5a2f78e..5f4731e3eeca91fe6aa649058d34871f378209e9 100644
--- a/Source/bindings/v8/BindingSecurity.h
+++ b/Source/bindings/v8/BindingSecurity.h
@@ -31,6 +31,8 @@
#ifndef BindingSecurity_h
#define BindingSecurity_h
+// FIXME: The LocalFrame include should not be necessary, clients should be including it where they use it.
+#include "core/frame/LocalFrame.h"
#include "wtf/text/WTFString.h"
#include <v8.h>
@@ -38,7 +40,6 @@ namespace WebCore {
class DOMWindow;
class ExceptionState;
-class LocalFrame;
class Node;
enum SecurityReportingOption {
@@ -49,8 +50,8 @@ enum SecurityReportingOption {
class BindingSecurity {
public:
static bool shouldAllowAccessToNode(v8::Isolate*, Node*, ExceptionState&);
- static bool shouldAllowAccessToFrame(v8::Isolate*, LocalFrame*, SecurityReportingOption = ReportSecurityError);
- static bool shouldAllowAccessToFrame(v8::Isolate*, LocalFrame*, ExceptionState&);
+ static bool shouldAllowAccessToFrame(v8::Isolate*, Frame*, SecurityReportingOption = ReportSecurityError);
+ static bool shouldAllowAccessToFrame(v8::Isolate*, Frame*, ExceptionState&);
};
}
« no previous file with comments | « no previous file | Source/bindings/v8/BindingSecurity.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698